You are not initialising the arrays correctly

my @jobvar_list=qw/senior exec/;
my @jobname_list=( " Senior", " Executive" );
my $n = @jobname_list; # length

[download]
They might be better as a hash anyway...the following code shows roughly how as well as some other changes... 

my %jobs = (
   'senior' => ' Senior',
   'exec' => ' Executive'
   );

my $quick_build='listing';
my $quick_jobtype='exec';
  
print "job types...<br>\n";
foreach my $key (keys %jobs) {
    print "$key, $quick_jobtype...<br>\n";
    my $jobvar = $key;
    my $jobname = $jobs{$key};

    if (($quick_jobtype && ($quick_jobtype eq $jobvar)) || (!$quick_jo
+btype)) {
        $groupfile = $jobvar;
        $grouptitle = $jobname;

        # heredocs are quite good for SQL...

        $sortby = <<EOF;
WHERE jobtype LIKE '%$jobvar%' AND active='yes' AND jobstatus!='suspen
+d' 
ORDER BY dateadded DESC, jobtitle ASC
EOF
        print "$sortby";
        print "starting build lists<br>\n";
        my $building_cat = "yes";

        # I don't know what this function does
        # but pass parameters to it, don't use global variables.
        # e.g. Build_Lists_Both( $sortby, $building_cat, $groupfile ) 
+;
    } # end if ($cat1 eq $cat_db_var)

}    
    

} # end for ($st=1; $st<=$jobvar_list; $st++)

[download]
If you spot any bugs in my solutions, it's because I've deliberately left them in as an exercise for the reader! :-)

In reply to Re: Help with a loop by space_monk
in thread Help with a loop by htmanning

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.