Monks,

I'm writing a search to go through an array of data, I'm looking for any suggestions on algorithms, structuring, or any language advice to make my code better. Also, what is a better way to build my regexes?

Thanks! 


search(["bobcat", "boomerang", "beer", "bat"], ["-bo"], ["b"]);

sub search {

   my ($data, $negative_criteria, $positive_criteria = @_; 
   my $temp_array;
   my $results;

   my $match_regex = join "|", @$positive_criteria;
   
   # remove trailing "-" which denotes negated criteria
   my $negative_regex = [map { s/^-//, $_ } @$negative_criteria];

   $negative_regex = join "|", @$negative_criteria;

   # filter through all matches to array
   foreach(@$data) {
      if ($_ =~ m/$match_regex/)
      {
         push @$temp_array, $_;
      }
   }

   # remove negative criteria and build new array
   foreach(@$temp_array) {
      if ($_ !~ m/$negative_regex/)
      {
         push @$results, $_;
      }
   }

   my $count = 0;
   foreach(@$results) {
      print "$count - $_\n";
      $count++;
   }

   return $results;

}

Output: 

0 - beer
1 - bat

[download]

In reply to General Advice by yoda54

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.