Fugly is subjective, of course. However, what do you think about this?

sub get_loc {
    chomp $_[0];
    
    # Aligned the "or" clauses with the main expressions
    my $dbh =
        DBI->connect("DBI:mysql:tracker:12.34.56.78", 'myuser', 'mypas
+sword')
        or die "Connect to database failed: $DBI::errstr\n";
    
    my $sth =
        $dbh->prepare("SELECT location FROM servers WHERE name=? LIMIT
+ 1")
        or die "Couldn't prepare statement: $DBI::errstr\n";
    
    $sth->execute($_[0]);
    
    # No point in assigning if you aren't going to use @loc anyway
    # return my @loc = $sth->fetchrow_array();
    return $sth->fetchrow_array();
    
    # This is dead code. Execution will jump out of the sub due to the
+ return statement above!
    # Put disconnect call and "or" clause on same line
    $sth->finish;
    $dbh->disconnect    or die "Error disconnecting: $DBI::errstr\n";

    # Aligned "}"-line with "sub get_loc {" line
}

[download]

In reply to Re: DBI Style Inquiry by muba
in thread DBI Style Inquiry by edict

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.