Do you think it will be more clear if it will return number of element to remove, and we remove it outside for loop?

Yes, IMHO. My approach, using my own conventions, would be something like this (untested): 

sub do_finish {

    my $self = shift;

    my ($jobid_to_delete) = @_;

    delete $self->{jobs_h}->{$jobid_to_delete};

    my $i_to_delete;
    my $ar_jobs_a = $self->{jobs_a};
    JID:
    for my $i (0 .. $#$ar_jobs_a) {
        my $jid = $ar_jobs_a->[$i]{jobid};
        next JID unless $jid == $jobid_to_delete;
        $i_to_delete = $i;
        last JID; 
        }

    splice @$ar_jobs_a, $i_to_delete, 1 if defined $i_to_delete;

    return @$ar_jobs_a ? 'ok' : 'done';

    }

[download]

Update: Renamed  $jobid to  $jobid_to_delete in interests of self-documentation.

In reply to Re^3: foreach argument modification inside loop, followed by return from loop by AnomalousMonk
in thread foreach argument modification inside loop, followed by return from loop by vsespb

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.