I agree with most of the above comments, and in particular, I would also stress how important it is to have "constant" data outside of your function.

Additionally, eliminating duplication is also a priority, though not at the expense of needless complexity. In this case, @SYS is really the same as keys %POvars, so there is no need for this extra definition.

Further along those lines, I would restructure your definition something like:

my @POvars_common = qw[ ppo userid email ];

my %POvars = (
        'GRP' => [@POvars_common, 'gwpo', 'gwdomain'],
        'JAG' => [@POvars_common, 'jagexcept'],
        'CIS' => [@POvars_common],
        'MST' => [@POvars_common],
        'GCG' => [@POvars_common]
);
[download]

Although this doesn't seem like a big deal, removal of duplication can help with:

• Accidental transposition errors, such as one of your entries having 'emall' instead of 'email', which is hard to spot amidst many similar lines. Using Perl with the '-w' option, and use strict will spot errors in your variable names, but not your string constants, unless these happen to generate errors as well.
• Errors when changing the structure on a global scale, which requires modifications to every single entry in this case. This usually happens to every program, so plan for it in advance.
• Synchronization errors between needlessly linked data structures, such as @SYS and %POvars, where one has an entry which the other does not.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.