This line...

$dbh->do('INSERT INTO users (name, day, phone) VALUES($name, $day, $nu
+mber)');

[download]

...makes two mistakes; one related to syntax and semantics, the other related to best practices. First, it's using single quotes but expecting interpolation. You use double quotes when interpolation is intended. 

my $bill = 'Text plus $ted'; # no interpolation.  
my $bill = "Text plus $ted"; # Interpolation occurs.

[download]

Second, and really more importantly, it's not using placeholders / bind-values. Do it like this:

my $sth = $dbh->prepare('INSERT INTO users (name, day, phone) VALUES(?
+,?,?)' );
$sth->execute( $name, $day, $number );

[download]

Placeholders and bind-values are described in the documentation for DBI. Their most important function is to prevent SQL injection attacks. They also protect you from unintentional interpolation which may not be malicious, but may be problematic nevertheless.


Dave

In reply to Re: MySql in cgi by davido
in thread MySql in cgi by Chaotic Jarod

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.