Welcome to the monastery, Salwrwr! I'm pretty sure nearly everyone has missed the <code> tags at least once.
A few general tips, and hopefully not too much overlap with the other replies you've already received:
- You're not doing any error checking on file operations. Either employ the usual idiom: open my $fh, '<', $filename or die "Can't open $filename: $!";, or use autodie; to obviate the need to code all the checks yourself.
- You can clean up the print syntax by using join slices: say $newfile join "\t", @line[0,2,3], @values[0..2]; (use 5.010 or later, or use feature 'say' to enable say.
- There's no need to repeatedly split and join @file_data (or even to create @file_data in the first place; do it outside the @position loop and store the result:
my @values = map { join "\t", (split /\t/)[0..2] } <$fh>;
# Later, in your say statement:
say $newfile join "\t", @line[0,2,3], $_ for grep { /^$start\t/ } @val
+ues;
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.