G'day viffer,

If you declare %params earlier in your code, you can write: 

        if ($server eq 'lsrch1') {
            my %params = map { $_ => 1 } @lsrch1;
            if(! exists($params{$string})) {
                push (@lsrch1, $string);
            }
        }

[download]

as: 

        if ($server eq 'lsrch1') {
            push @lsrch1, $string unless $params{$string}++;
        }

[download]

You haven't shown the context of your code (which is fine); however, it leaves me in the dark as to advising where exactly to delare %params. Also, I don't know where $string comes from. Here's my test showing how my code might be implemented (adapt for your context as appropriate): 

$ perl -Mstrict -Mwarnings -e '
    my @strings = qw{a a a b b c d d e e e};
    my $server = "lsrch1"; # Fudge for demo
    my @lsrch1;
    my %params;

    for my $string (@strings) {
        if ($server eq "lsrch1") {
            push @lsrch1, $string unless $params{$string}++;
        }
    }

    print "\@strings:     @strings\n";
    print "\%params keys: @{[sort keys %params]}\n";
    print "\@lsrch1:      @lsrch1\n";
'
@strings:     a a a b b c d d e e e
%params keys: a b c d e
@lsrch1:      a b c d e

[download]

-- Ken

In reply to Re: Checking if an item exists in an array before adding a record to it. by kcott
in thread Checking if an item exists in an array before adding a record to it. by viffer

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.