G'day pldanutz,

I generally think it's better to pass around scalars than entire data structures, so returning a reference to that hash would be my preference.

If you wrapped $h{$k} in @{...}, you could dispense with if (! $h {$k}) { $h {$k} = [] } entirely.

Even if you're using 5.012 for other reasons elsewhere in your code, I see little, if any, value in using each here. It's easy to write it for any Perl5.

Putting all that together, you could code occurrences() like this instead: 

sub occurences {                                                    
    my %h;          
    my $i = 0;
    push @{$h{$_}}, $i++ for @_;
    return \%h;
}

[download]

If you were looking for a golf answer, you could start with the following and then proceed to remove whitespace until illegibility was achieved. :-) 

sub occurences { my ($i, %h) = 0; push @{$h{$_}}, $i++ for @_; \%h }

[download]

Here's my tests:

<Reveal this spoiler or all in this thread>

-- Ken

In reply to Re: array => hash of occurrence indexes by kcott
in thread array => hash of occurrence indexes by pldanutz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.