G'day spstansbury,

I see Tux has provided you with a better way to tackle your task. The reason you're getting the results you see with your posted solution is as follows.

Given this test.csv (newlines shown as "$" and tabs as "^I"):

$ cat -vet test.csv quote at end"$ no quote at end$ quote and space at end" $ quote and tab at end"^I$

Your posted code matches every line:

$ perl -ne 'print $_ if $_ =~ /[^"]$/' < test.csv quote at end" no quote at end quote and space at end" quote and tab at end"

The reason for this becomes apparent when you look at exactly what $_ contains:

$ perl -ne 'print ">>>$_<<<\n" if $_ =~ /[^"]$/' < test.csv >>>quote at end" <<< >>>no quote at end <<< >>>quote and space at end" <<< >>>quote and tab at end" <<<

Each line ends with a newline which, not being a double-quote, means /[^"]$/ matches.

You can get around this most easily but simply using the -l switch:

$ perl -lne 'print $_ if $_ =~ /[^"]$/' < test.csv no quote at end quote and space at end" quote and tab at end"

If you look at perlrun, you'll see that's equivalent to chomping each input line and appending a newline (or whatever the current value of $/ is) to each output line:

$ perl -ne 'chomp; print "$_\n" if $_ =~ /[^"]$/' < test.csv no quote at end quote and space at end" quote and tab at end"

[Note: the -l switch is a little more complicated than my simplistic explanation - see the doco for details.]

-- Ken


In reply to Re: Trying to find missing closing quotes in CSV by kcott
in thread Trying to find missing closing quotes in CSV by spstansbury

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.