You're welcome, again -- are you up for a little code analysis? There are a few things in the script as you've modified it which really ought to be adjusted if you have the time. 

  1.   open(NPBXNUM1, ">npbxnum1");
  open(MYINPUTFILE, "npbxnum");

    [download]
    You went through the effort of specifying > on the output file; consistency has much value in engineering. Why not boldly include the < on the input file? 
      open(NPBXNUM1, ">npbxnum1");
  open(MYINPUTFILE, "<npbxnum");

    [download]
    And I'm sure other Monks would strongly recommend breaking the < and > out into their own parameters, for reasons I don't pretend to understand: 
      open(NPBXNUM1, '>', "npbxnum1");
  open(MYINPUTFILE, '<', "npbxnum");

    [download]
  2. while (<MYINPUTFILE>) {
   my($line) = $_;
   chomp($line);

    [download]
    probably better as: 
    while (my $line = <MYINPUTFILE>) {
   chomp($line);

    [download]
  3. foreach my $inputData ($line) {
  my $outputData = $inputData;
  while (length($outputData) < 4) {
    $outputData .= '_';
  }
  print NPBXNUM1 "$outputData\n";
}

    [download]
    The foreach loop is pointless, as its purpose is to iterate through an array; $line is a scalar.

    Perhaps better as: 

      my $outputData = $line;
  while (length($outputData) < 4) {
    $outputData .= '_';
  }
  print NPBXNUM1 "$outputData\n";
}

    [download]

In reply to Re^5: How to have perl check line length by marinersk
in thread How to have perl check line length by ddrew78

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.