Why do you copy your file and then move it? It would be simpler to just copy it directly to the right destination. By the way, File::Copy provides both a copy and a move function.

The fact that you had to copy and paste the same code 4 times should have been a good clue that you could have done it better. And if you are just going to use index to know if a string is included in the other, a regex could do the trick, with case insensitivity made easy.

use strict;
use File::Copy;
use warning;

system("clear");

system("mount /dev/cd0 /mnt");
system("cp /mnt/* /usr/castle/pctemp/.");
system("umount /mnt");

my %dest = 
    (SO_PC => 'PCMAP.BIN',
     MS_PC => 'FULLPC.BIN',
     SO_CV => 'CVFULLPC.BIN',
     MS_MC => 'MBFULLPC.BIN');

print "\n" x 5, "Input required:\n";

my $fileName = <STDIN>;
chomp $fileName;
for my $search (keys %dest)
{
   die "$fileName does not exist!" unless -e $fileName;
   copy ($fileName, '/usr/castle/np_new/'.$dest{$search}) if $fileName
+ =~ /\Q$search/i;
}

[download]

In reply to Re: Filename Partial Match function by Eily
in thread Filename Partial Match function by Jalcock501

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.