I really recommend you use proper indentation for your blocks. This will make the error quite obvious. Indent the content of each block by four spaces:

#!/usr/bin/perl use strict; use warnings; my $filename = "filet.txt"; my $emailRE='/(\b[\w\.@]+\b)/'; my @emails=(); my $email; my $mail; while (<>) #for each line in each file { @emails = (/($emailRE)/og); #get all the emails on this line foreach $email (@emails) { print "$email, $.\n"; open(FILE, ">$filename") or die "Can't write to $filename: $!" +; print FILE $email; } # print them out #close FILE; }

As a second step, I recommend printing out the progress of your program. For example, add a warn statement when you open your output file.

Also, you may want to learn about the arguments to open. Especially take a look at what > means - it means create-and-overwrite.


In reply to Re: extracting from 1 file and adding to another. by Corion
in thread extracting from 1 file and adding to another. by scripter87

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.