I can't (yet) work out how to code _next() in Perl.

I like a challenge, but my first try — a one-for-one translation from C into Perl — seems to work fine:

#! perl -slw use strict; permIt(split '', 'ABC---'); sub _next { my ($v) = @_; my $t = ($v | ($v - 1)) + 1; return ($t | (((($t & -$t) / ($v & -$v)) >> 1) - 1)); } sub permIt { my $l = @_; my @chars = grep $_ ne '-', @_; my $n = my $s = (1 << @chars) - 1; do { my $bits = pack 'V', $n; my @copy = @chars; my $str = join '', map { vec( $bits, $_, 1 ) ? shift( @copy ) : '-' } +0 .. $l - 1; print $str; $n = _next($n); } until ($n > ($s << ($l - @chars))); }

Output:

17:18 >perl 760_SoPW.pl ABC--- AB-C-- A-BC-- -ABC-- AB--C- A-B-C- -AB-C- A--BC- -A-BC- --ABC- AB---C A-B--C -AB--C A--B-C -A-B-C --AB-C A---BC -A--BC --A-BC ---ABC 17:18 >perl -v This is perl 5, version 18, subversion 1 (v5.18.1) built for MSWin32-x +86-multi-thread-64int ...

What am I missing?

Athanasius <°(((><contra mundum Iustus alius egestas vitae, eros Piratica,


In reply to Re^2: combinations of given string by Athanasius
in thread combinations of given string by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.