How about undoing some of those loops. If your file names are as consistent as they look from your example, this is a simpler way to do it
#!/usr/bin/perl
use strict;
use warnings;
# Read barcodes, and look for coresponding files to rename
my $dir = "/samplesA";
my $bcf = "/ID.txt";
open my $barcodelist, "<", $bcf or die "Can not open barcode file $bcf
+: $!\n";
while (my $line = <$barcodelist>) {
chomp;
my ($id, $barcode) = split(/\t/,$line);
# I like validating inputs
warn "bad line at $.\n" unless $barcode =~/^[ACGT]+$/;
my $file = "$dir/sample_$barcode.fq";
if (-e $file) {
my $new = "$dir/$id.fq";
rename $file, $new or die "Can't change $file to $new, $!\n";
}
}
close $barcodelist;
Cheers,
R.
Pereant, qui ante nos nostra dixerunt!
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.