Your code is in severe need of simplification and cleanup before we can consider whether using File::Find would improve it.

For example, write off the bat I detected three variables which are declared but never used: 

$size
$name
$SDIR

[download]
Get rid of them -- and while you're removing them, also delete all the commented-out code, which only serves as a distraction to those reading your post and trying to help you.

Next, note that on line 56 you assign $drive to $dirlist[0], and then within five lines you call for a loop over the contents of @dirlist. If you only have one entry in the list over which you are iterating, you can ditch the for loop as well.

Thank you very much.

Jim Keenan

In reply to Re: File::Find Question by jkeenan1
in thread File::Find Question by RockE

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.