As I said, I'm a self-taught perl user and best considered beginner level =)

I tried explaining my reasoning behind how I accessed the args in subs.
I've been looking into oop because in this script there's a lot of expect usage and I want to create re-uasable and well structured subs. (currently that'snot the case)
Below is a case where I have used shift. 

sub set_timeout {
    my $self = shift;

    my $to = $self->{timeout};

    if (@_){
        $self->{timeout} = shift;
        
    }

    return $to;    
}

[download]
In this case shift makes sense imo, although it could have just as well been written like this.
sub set_timeout {
    my $self = $_[0];

    my $to = $self->{timeout};

    if ($_[1]){
        $self->{timeout} = $_[1];
        
    }

    return $to;    
}

[download]
The reason I didn't use the index based assignment is that shift feels better here and in the documentation I read about oop they exclusively used shift accessing. However in a different scenario like below I don't think using shift in the if clause makes sense.
sub set_stuff {
    my $self = shift;
    
    if (@_){    
        $self->{stuff1} = shift;    #3 lines for one task
        $self->{stuff2} = shift;
        $self->{stuff3} = shift;
        ($self->{stuff1},$self->{stuff2},$self->{stuff3}) = @_; #1 lin
+e, same result regardless of stuff presence
    }

    return 1;    
}

[download]
So what I'm saying is I used shift when I felt like it without having a clue whether it's faster or better than index based assignment. =)

In reply to Re^5: RFC: beginner level script improvement (various comments) by georgecarlin
in thread RFC: beginner level script improvement by georgecarlin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.