Let me disagree, even if the original code was not the worst example I could have brought up.
  1. I was staring at the code for a long time before I understood what it does (originally, there was inconsistent indentation, global variables with meaningless names, almost no whitespace). I had to run it to see whether the numeric constants were correct and what the behaviour was for larger numbers.
  2. Here I have to agree. I was not satisfied with my solution, that was why I asked here. To run an exhaustive test, you can modify the list to 
    q(), 0 .. 1e12

    [download]
    Reserve enough time, though.
  3. Business justification: I am the maintainer of the code. If the code changes only when fixing bugs, it will stay in the nineties and become unmaintainable. Without refactoring, the code becomes dead, and accumulates risk: at one point in the future, a bug or feature request will appear that will not be possible.

    Working with always enough assigned tickets to prevent any creativity leads to exhaustion. It will make me leave your company, which means «business cost»: you invested in the hiring process and in training me. Moreover, trust (both to expert opinions and business decisions) makes the working environment better.

لսႽ† ᥲᥒ⚪⟊Ⴙᘓᖇ Ꮅᘓᖇ⎱ Ⴙᥲ𝇋ƙᘓᖇ

In reply to Re^2: Can you make it nicer? by choroba
in thread Can you make it nicer? by choroba

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.