I'm a little nervous to comment... I hope this won't offend anyone...
IMVHO I think the clearest code is rminner's code.
IMVVHO The 2nd clearest is ... oh look over there, a spider ... *whispers* the original code.
IMVVVHO Both make it very clear what the 2 different cases are, and what to do for each of them.

I like to line things up to help highlight the similarities and differences, so I might write it like this: 
sub id2path_new {
    my ($id) = @_;
    return '' unless $id;

    my $path = '';

    if ($id >= 1_000_000) {  $path = sprintf("%09d", $id);  $path =~ s
+#\A(.*)(...)(...)\z#$1/$2/$3#;   } 
    else                  {  $path = sprintf("%06d", $id);  $path =~ s
+#\A(..) (..) (..)\z#$1/$2/$3#x;  }
    return $path;
}

[download]

In reply to Re: Can you make it nicer? by zork42
in thread Can you make it nicer? by choroba

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.