Just to illustrate I have rewritten your script to use DBI.
Note that I don't have access to Oracle so I haven't tested it.

The rewrite is quite simple:

#!/usr/bin/perl -w

use strict;
use DBI;
use Env;

my $DB = "DBNAME";
my $UN = "USERNAME";
my $PW = "PASSWORD";
my ($dbh,$sth,$clli,$c);

$dbh = DBI->connect("dbi:Oravel:$DB",$UN,$PW,
     {AutoCommit => 0, RaiseError => 1) or
              die("Oracle login FAILED, $DBI::errstr");

$sth = $dbh->prepare("select distinct(clli) from gvc_traffic30");
$sth->execute;

$sth->bind_col(1, \$clli);
while ($sth->fetchrow_arrayref ) {
    $c++;
    if ($clli =~ /\W/ ) {
      print "Found bad character in line $c.";
    } else {
      print "This clli appears to be OK.";
    }
    print " : $clli\n";
}

[download]
Note that I don't do any error checking. This is because I set $dbh->{RaiseError} in the connect call, so the DBI will do all neccessary errorchecking for me!

Check the DBI documentation to see what this does.

Happy DBI'ing

In reply to Re: Re: Using DBI for the first time... by htoug
in thread Using Oraperl for the first time... (was: Using DBI for the first time...) by snafu

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.