Nice job, imho, but allow me two random remarks:
and I would - if it wasn't useless - prefer to write the line as $recipient = "root" unless (defined($recipient)); but that's more a matter of taste...my $recipient = "root"; unless (defined($recipient)) { $recipient = "root" } # useless
substr($message{detail}, 32, 8) =~ /(\w\w)(\w\w)(\w\w)(\w\w)/; $message{mml} = pack ("CCCC", hex($1), hex($2), hex($3), hex($4)); # simply $message{mml} = pack ("H*", substr($message{detail}, 32, 8));
-- Hofmator
In reply to Re: how can this be improved?
by Hofmator
in thread how can this be improved?
by blueflashlight
| For: | Use: | ||
| & | & | ||
| < | < | ||
| > | > | ||
| [ | [ | ||
| ] | ] |