Those are not the same statement. The first only sets $recipient to "root" if $recipient is undef. The second sets it if $recipient is "" or 0, as well.

One big suggestion I have is to break things out into functions and put those functions in a module. Use that module and your script becomes much smaller. But, that's not the big savings. Say, for instance, you want to do something similar, but not quite the same. You just re-use a bunch of functions and your development time is cut dramatically. In addition, you already know that the funtions in this module are debugged correctly, so you can trust them! :)

------
/me wants to be the brightest bulb in the chandelier!

Vote paco for President!

In reply to Re: Re: Re: how can this be improved? by dragonchild
in thread how can this be improved? by blueflashlight

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.