Apart from the style, why do you have an else block after return. I understand that you want to give an example of the style you require, but there is more than style: there should *NEVER* be an else after return, exit or die. These three exit the surrounding scope immediately, so the code *after* else is never executed. Retaining your style, that code should read:

sub old_code
    {
    my $self = shift;
    my $file = shift;
    
    if (-e $file) 
        {
        open(my $fh, "<", $file) or die "cannot open < $file: $!";  
        # Do something with the file
        return 1;
        }

    die "$file not found";
    };

[download]

Which I would simplify to

sub old_code
    {
    my $self = shift;
    my $file = shift;
    
    -e $file or die "$file not found";
 
    open(my $fh, "<", $file) or die "cannot open < $file: $!";  
    # Do something with the file
    return 1;
    }

[download]

Enjoy, Have FUN! H.Merijn

In reply to Re: perltidy block indentation by Tux
in thread perltidy block indentation by saltbreez

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.