The only thing I see that others have not mentioned falls into the 'never trust user input' category:
my $sequence_number = shift ||
die "cinnamon: sequence number needed as argument\n";
open (ERROR, "/usr/bin/errpt -g -l $sequence_number |");
You're passing whatever the first parameter is directly to the open, and you're not checking to see if the open failed. Here's a modification with a little more paranoid error checking.
my $sequence_number = shift;
unless ($sequence_number =~ /^\d+$/) {
# I am assuming it must be a number
die "cinnamon: sequence number needed as argument\n";
}
open (ERROR, "/usr/bin/errpt -g -l $sequence_number |") || die "couldn
+'t open errpt: $!";
/\/\averick
perl -l -e "eval pack('h*','072796e6470272f2c5f2c5166756279636b672');"
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.