If it ain't broke, don't fix it. Some stuff to think about:
- Is there a compelling reason for the calling code to know about implementation details?
- Is there a compelling run time issue the change would fix?
- Is there a compelling maintenance issue the change would fix?
- Are you confident you won't introduce bugs making the change?
- Does all the affected code have unit tests?
- Is this the most important thing you can be doing right now?
- Does this change advance your carer or improve your coding ability?
Not all considerations are completely serious, but decide which are important to you, or if there are others I've missed, and think about those criteria to make your decision.
True laziness is hard work
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.