Your problem is in this part:

while(<COUNT>){
  if(/^$/){}else{
  ($OS_Name,$count)=split /=/;
  chomp($OS_Name);
  chomp($count);
  $OS_Count{$OS_Name}=$count;
}

[download]

You missed a bracket for the "else". I'd probably code this something like this:

while(<COUNT>){
    next if /^\s*#?\s*$/; # skip blank lines (the hash mark lets you a
+dd comments)
    chomp;
    ($OS_Name,$count)   = split /=/;
    $OS_Count{$OS_Name} = $count;
}

[download]

As for the "premature end of script headers", when you click links for Linux or Windows, you forgot to print the redirect :)

    print $CGI->redirect($file);

[download]

Cheers,
Ovid

Vote for paco!

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.

In reply to (Ovid) Re(2): Advice on a CGI script by Ovid
in thread Advice on a CGI script by TStanley

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.