You've received excellent scripting suggestions. Still, perhaps the following minor modifications of your script will be helpful:
use strict;
use warnings;
use DateTime;
use POSIX qw(strftime);
use autodie;
open my $logFH, '<', 'second.txt';
while (<$logFH>) {
my ( $streamname, $streamid, $timedate ) = split /[@\s]/;
my $time_t = POSIX::strftime( "%Y-%m-%d %r", localtime($timedate)
+);
open my $fh, '>', "$streamid/$streamname";
print $fh <<END;
<event>
<stream-id>$streamid</stream-id>
<event-name>$streamname</event-name>
<primary-event>
<delete-time>$time_t</delete-time>
</primary-event>
</event>
END
}
- Always: use strict; use warnings;
- Used a single split
- Used the three-argument open()
- Used a here document for printing.
- A close is absent above, since the currently-opened file will automatically close when a new handle is assigned to $fh
Edit: Added use autodie; to catch any silent close failures. Thank you, davido.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.