Hi everyone, i have done create a script where a portion of the script will search through a file (line by line) in comparison of an array. The end goal of this portion is to flag out "error message" if there is no such element from the array in the file that i am searching.

I try to solve this using two different ways of looping through a file and i found the solution by choosing the 1st method

My Question is there any other preferred solution to solve this?

I do paste a snippet of my code and the generated output here for reference.

The first method 

 use strict;
use warnings;
use Getopt::Long;
my ($cfg,$files,$output); 
$output = 'Output.summary';
GetOptions ('cfg=s' => \$cfg, 'rtl=s' => \$files); 
open my $fh1, '<', $cfg or die "Can't open $cfg: $!"; 
open my $fh2, '<', $files or die "Can't open $files: $!"; 
open my $fh3, '>', $output or die "Can't open $output: $!";

my @array_1 = <$fh2>;
my ($element);
my ($data_1,$data_2,$data);
my %hash ;

while (<$fh1>) {
 $data = $_;
 chomp $data;
 next unless /\S/;
 foreach  $element(@array_1) {
 next unless /\S/;
 chomp $element;
 if ($element =~ quotemeta($data))
 {
 $hash{$data} = "$data exist_1";
 last;
 }
 else {
 $hash{$data} = "$data doesn't exist";
 }
 }
}

while (my($key,$value) = each(%hash)) {
print $fh3 "$key => $value\n";
}

[download]

Second method (edit the following lines only) 

 
my @array_1 = <$fh1>;

while (<$fh2>) {

 if ($data =~ quotemeta($element))
 {
 $hash{$element} = "$element exist_1";
 last;
 }
 else {
 $hash{$element} = "$element doesn't exist";
 }
 }
}

[download]

Output for the 1st method followed by the 2nd method 

 
xdrvo[93] => xdrvo[93] exist_1
x106_in => x106_in exist_1
hlkout => hlkout exist_1
xdrvo[63] => xdrvo[63] exist_1
v7drvo0 => v7drvo0 exist_1
xdrvo[1002] => xdrvo[1002] doesn't exist
xdrvo[95] => xdrvo[95] doesn't exist
x95_in => x95_in exist_1

[download]

2nd one

xdrvo[93] => xdrvo[93] doesn't exist
x106_in => x106_in doesn't exist
hlkout => hlkout doesn't exist
xdrvo[63] => xdrvo[63] doesn't exist
v7drvo0 => v7drvo0 doesn't exist
xdrvo[1002] => xdrvo[1002] doesn't exist
xdrvo[95] => xdrvo[95] doesn't exist
x95_in => x95_in doesn't exist </p>

[download]

Thank you in advance for all the folks out there who will reply and help to explain on this. From my opinion, one key point to consider is the line number differences for the cfg_file and the main file(where it search line by line).

In reply to Looping two files differently by noob_mas

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.