what fun!

Here are my suggestions...

Add a log function: 

sub log {
  open (LOG,">>log") || die $!;
  print LOG "$_[0]\n";
  close LOG;
}

[download]
Then, at the beginning and end of each sub-routine, add: 
sub sub-name {
  log("Entering sub-name");
  ...
  log("Leaving sub-name");
}

[download]
Then add various log calls when things happen that you're unsure of, tacking vars used. eg: 
log("querying VAX: $vaxen_query");
execute $vaxen_query;

log("SQL query: $mangled_sql_query");
execute $mangled_sql_query;

[download]
Adding some vars fom caller() may also give you some added insight.

Once you have some idea what gets sent where and when, you can replan what the scipt does and rewite cleanly.

HTH

cLive ;-)

In reply to Re: Best way to fix a broken but functional program? by cLive ;-)
in thread Best way to fix a broken but functional program? by idnopheq

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.