Untested code, but I hope it will give you a hint or two...

use strict; # Please use warnings; # Please # $n = 0; # There may be a better way # 'my' added to localise the scope of these variables # It won't matter much now, but when you get to large programs its a l +ife saver my $logz = '/var/log/syslog'; my $file = '/home/user/Desktop/keywords'; # Nowadays we use the three parameter form of open. # its good to check the results too. # open(LOGFILE, $logz); # open(KEYWORD, $file); open my $log, '<', $logz or die "Can't read $logz: $!\n"; open my $keys,'<', $file or die "Can't read $file: $!\n"; # I guess you want to check the keys against each logline # here I am going to take a different approach # Dont read the log all in one go, we will just check it line # at a time # @keyWord = <$keys>; # @logFile = <LOGFILE>; # precompile the regex for the keys my %re_key; # regex compiled keys while (my $pattern = <$keys> ) { # check each key chomp $pattern; # remove line ending $re_key{$pattern} = qr/$pattern/; # store in a hash } # $keyz = @keyWord[$n]; # this was only looking at one key. while (my $line = <$log> ) { for my $pattern (keys %re_key) { print "$pattern matched in $log" if $line =~ /$re_key{$pattern +}/; } }

Cheers,
R.

Pereant, qui ante nos nostra dixerunt!

In reply to Re: Arrays and grep problems by Random_Walk
in thread lolhackedlol by perlmonknoob

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.