tarun28jain:

A couple items:

• Your read_line function isn't returning a file position, so write_log won't be able to seek to the correct location. Instead, you're returning the contents of a line. If it happens to be a number, then you may be changing a line pretty far away from where you intend!
• It looks like you're confusing file position (the index of the current byte in the file) with line number (how many lines have we read so far).
• If you fix these problems, you'll find that if your new text is a different length than the original line, you'll either leave garbage in your file, or overwrite some of the next line(s).

Typically, if you want to make an edit in the middle of the file, you'll want to rewrite the entire file, unless your substitution text has the same number of bytes as the text it's replacing. (Can be complicated, especially when Unicode is involved.)

I'd suggest doing it a bit more like:

open my $INF, '<', $filename;
open my $OUF, '>', $filename . ".new";

my @lines = <$INF>;
$lines[2] = "12345\n";

print $OUF @lines;
[download]

However, reading the entire file into memory may be a problem, so you may want to process line-by-line instead.

...roboticus

When your only tool is a hammer, all problems look like your thumb.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.