Well, unless you're sure that $TheRec is left empty, in which case we should start there, I'd look at your other while() loops. For example, the next one: while ($NewItem[$z]) { ... } will fail similarly to your old while (<IN>) loop. To rectify this one, for instance, you might need to switch to something more like while(defined($NewItem[$z])) or somesuch.

Although there's nothing really wrong with the way you expressed this, by the way, it is more idiomatic to write the loop like this:

  # Itterate over the contents of the @NewItem list
  # For each item in the list, set $item to the value
  # (equivalent to $NewItem[$z] in your code)
  foreach my $item (@NewItem) {
    # And add this value in like you did before.
    $SQLString = $SQLString . $item . "\',\'";
  }

[download]

And even that's a little more loose that it could be.

At any rate, go back and refactor your code, looking for more places to stick watch for the defined-but-false condition. And be sure that $TheRec is actually coming back blank.

Hope this helps!
--jwest

-><- -><- -><- -><- -><-
All things are Perfect
    To every last Flaw
    And bound in accord
         With Eris's Law
 - HBT; The Book of Advice, 1:7

In reply to Re: Re: Re: while(INFILE) terminating before finishing file. by jwest
in thread while(INFILE) terminating before finishing file. by sdyates

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.