G'day Monk::Thomas,

The documentation for the close function has information on filehandles associated with pipes. It includes this example code which (with appropriate modification) may be a better choice for your script: 

    ...
    close OUTPUT
        or warn $! ? "Error closing sort pipe: $!"
                   : "Exit status $? from sort";

[download]
"(I'm wondering why there's carp instead of croak, but that's a different issue.)"

carp will output a message and keep going while croak will output a message and terminate the script (see Carp for details).

You say the code you posted "is part of a subroutine". There could be any number of reasons for not terminating the script at this point. Without knowing what else the script is doing, it's impossible to say (including whether croak would be more appropriate).

-- Ken

In reply to Re: close $fh fails on a single host - looking for explanation by kcott
in thread close $fh fails on a single host - looking for explanation by Monk::Thomas

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.