G'day PilotinControl,
Issues with the code you posted:
-
Get into the habit of using lexical filehandes and the 3-argument form of open.
The documentation has details.
-
Check that your I/O was actually successful.
Either hand-craft code for every I/O operation (open has examples) or use the autodie pragma;
the latter is my normal preference as it's both less error-prone and far less work.
-
You read all your data twice (while and for loops).
You only need to do this once.
-
I found your use of $lines (plural) confusing on first reading.
That variable contains a single line: $line would be more appropriate and less of a maintenance issue.
-
You chomp the array on every iteration of the for loop.
You should do this once before you start the loop.
-
You create a Tk::BrowseEntry widget on every iteration of the for loop.
You should do this once before you start the loop.
-
See insert() in the Tk::BrowseEntry METHODS section.
The syntax is insert(index, string).
Your usage of insert(index, array) possibly explains the earlier my @owners = $owner[1]; (which I found confusing when I first encountered it).
-
While you can chain methods (e.g. BrowseEntry->pack->insert), you don't have to.
Assign widgets you create to a variable; subsequently, use that variable to invoke methods.
The following script shows the guts of what you need.
#!/usr/bin/env perl
use strict;
use warnings;
use Tk;
use Tk::BrowseEntry;
my $mw = MainWindow->new;
my $ctrl_F = $mw->Frame->pack(-side => 'bottom');
$ctrl_F->Button(-text => 'Exit', -command => sub { exit })->pack;
my $app_F = $mw->Frame->pack(-side => 'top');
my $be = $app_F->BrowseEntry->pack;
while (<DATA>) {
chomp;
$be->insert(end => (split /:/)[1]);
}
MainLoop;
__DATA__
prefix:Owner A
prefix:Owner B
prefix:Owner C
As you can see, although that's very short, it's a working script that you can run (as is).
It contains no distracting noise (e.g. widget decorations, foreground/background colours, etc.) and merely addresses the issue at hand.
Please attempt to provide something like this when you post your next question.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.