Hello Monks! I am practicing perl by picking up text parsing questions from Stack Overflow. I came across a question where I had to transpose column such that following dataset

id1 name1 cat1 catname1 id1 name1 cat2 catname2 id2 name2 cat3 catname3 id3 name3 cat1 catname1 id3 name3 cat4 catname4

would become

id1 name1 cat1:catname1, cat2:catname2 id2 name2 cat3:catname3 id3 name3 cat1:catname1, cat4:catname4

I wrote a perl script, and even though it works as expected, I am in need of some wisdom. I wanted to know if there is a more idiomatic way of doing:

my @val = split(" ",$val); my $v = join (":", @val);

and

if (exists $hash{$key}) { $hash{$key} .= $sep.$v; } else { $hash{$key} = $v; }

Here is my complete perl script. Any advice and or suggestion to improve this will be greatly appreciated. This is my first post here at perlmonks, so if I missed on any crucial details, I apologize for that. Looking forward to be hearing from perlmonks.

#!/usr/bin/perl use strict; use warnings; use Data::Dumper; my %hash; my $sep = ", "; while (<DATA>) { chomp; (my $key, my $val) = /(\S*\s*\S*\s*)(\S*\s*\S*\s*)/; my @val = split(" ",$val); my $v = join (":", @val); if (exists $hash{$key}) { $hash{$key} .= $sep.$v; } else { $hash{$key} = $v; } } foreach my $k (sort keys %hash) { print $k.$hash{$k}."\n"; } #print Dumper \%h; __DATA__ id1 name1 cat1 catname1 id1 name1 cat2 catname2 id2 name2 cat3 catname3 id3 name3 cat1 catname1 id3 name3 cat4 catname4

I could have used better variable names but this was just for practice so didn't really focus on that part.


In reply to Appending values to existing hash key by jaypal

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.