Hi Sabiha

There can be many reasons for things not working. Using the right modules can help you to determine this effectively. Within development CGI::Carp is very useful as it can report errors succintly. There are also modules designed to help with logging log4perl comes to mind, but there are plenty on cpan

You have put code into a script which you import? You do not show this, but common errors are permissions and compilation. The former is a system error and the latter is a syntax error.

Running the system command to call a perl script is likely unecessary in your case and leads to being unable to determine the type of error. Being a perl script there are many ways that the script can be called and run from within your script without reverting to opening a whole new process, and which will report your errors plainly. Not to mention the security concerns you are opening up by doing this.

Firstly, place the external code to run into a subroutine within your script. Any compilation errors will show up straight away. If you have a lot of extra code that is used then put that subroutine into another file and import the file when it is needed.

I show using the do approach, it is old and you are better off just to put the sub into the existing script, but it can show the errors through the die if... constructs. If I make the script to run unexecutable and unreadable chmod u-rx ./scriptname I will get a system error reported using do. Using require, will prevent namespace clashes which using do causes, but will only tell you it cannot find the file in the @INC path. Using require is preferred, and suggested.

Two further points to do with security, untaint and filehandles. Cleanse your incoming paramaters by untainting them, so they are not used to gain access to serverside files/databases. And use $fh filehandle references and three argument open to handle them. That is seperate the mode >> from the filepath. For the same but not exclusive, reasons

Try not to use system unless you really cannot help to, most utilities such as mkdir, chmod etc.. are already perl built-ins, but if you must, then I would suggest to construct the @systemcommand array whether the list is coming in from standin or even if I call it by itself from within the script, that way he using the same construct each time and need not worry about if they am applied the argument safest or many unever.

Chances are you have left out the ending 1; in your importing script or, it is not executable/readable (permissions), also check your pathnames, are they full and correct paths?

cgi script

#!/usr/bin/perl -T

use warnings;
use strict;
use CGI;
use CGI::Carp qw(Fatalstobrowser Warningstobrowser);
use CGI::Pretty;

my $q = CGI->new;

...

# my @runutil = qw(/usr/bin/util arg arg /path/arg/file );
# system { $runutil[0] } @runutil;

my $taintedvar = $q->params('user_id');
my ( $safervar ) = ( $taintedvar =~ /^(\w+)$/ );

do '/lair/supervillain/X/Evil/ransomdemands.pl';

die 'syntax: ', $@ if $@;
die 'system: ', $! if $!;

my $thingtoprint = &show($safervar);

open my $logfile, '>>', '/path/to/log';

print { $logfile } $thingtoprint,"\n";

close $logfile;

...

[download]

ransomdemands.pl

#!/usr/bin/perl

use warnings;
use strict;

sub show{
  my $name = shift;
  my ( $safername ) = ( $name =~ /^(\w+)$/ ); 
  return 'six hundred zagillion $$ to the account of '.$safername;
}

# end on true if exporting script
1;

[download]

I sincerely hope I have not added to your confusion here. Please do reply with the problem you find.

In reply to Re: Printing output of perl cgi to a file by Don Coyote
in thread Printing output of perl cgi to a file by Sabiha

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.