This is a somewhat shorter version, using a dispatch table (drawing some bits and pieces from your and marto's code).
#!/usr/bin/perl use strict; use warnings; print"###simple calculator program##\n\n"; my $opt2 = "y"; my %operations = ( "+" => sub { return $_[0] + $_[1]}, "-" => sub { return $_[0] - $_[1]}, "*" => sub { return $_[0] * $_[1]}, "/" => sub { return $_[0] / $_[1]} ); while ($opt2 eq "y"){ print "enter the first number\n"; chomp( my $num1 = <> ); print "enter the second number\n"; chomp( my $num2 = <> ); print "enter your option\n\+ for addition\n\- for subtraction\n\* +for multiplication\n\/ for divison\n option:"; chomp(my $opt = <>); print "you have entered wrong option\n" and next unless defined $o +perations{$opt}; print "you pressed the $opt key\n"; print $operations{$opt}->( $num1, $num2), "\n\n"; print "do you want to continue press y or n?\n"; chomp ($opt2 =<>); }
The good thing about this technique is that if you want to add an operation, say exponentiation, you only need to add one single line of code in the dispatch table (well, plus one line in your menu option). In addition, the return statement is not needed in the subs defined in the dispatch table (a function returns the last evaluated expression), so that the dispatch table could be:
my %operations = ( "+" => sub { $_[0] + $_[1]}, "-" => sub { $_[0] - $_[1]}, "*" => sub { $_[0] * $_[1]}, "/" => sub { $_[0] / $_[1]}, "**" => sub { $_[0] ** $_[1]} );
.

In reply to Re: help me to find out the error?? by Laurent_R
in thread help me to find out the error?? by dacka

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.