Instead of doing this…

    open(FILE, '/location/data/p4.txt') or die "Cant't open file: $!\n
+";

[download]

…do this…

    use strict;
    use warnings;
    use autodie qw( open close );

    # ...

    my $file = shift; # The input file name is a command-line argument

    open my $fh, '<:encoding(ASCII)', $file; # Or whatever the correct
+ character encoding is

    # ...

    close $fh;

[download]

And instead of doing this…

    my %myhash = ();
    my @data = ();

    chomp(@data = <FILE>);
    foreach (@data)    {
        %myhash = (@data => $k++);
    }

[download]

…do this…

    my %total_values_by;

    while (my $value = <$fh>) {
        chomp $value;
        $total_values_by{$value}++;
    }

[download]

In reply to Re: Learning Perl, Hashes Help by Jim
in thread Learning Perl, Hashes Help by learningmanylang

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.