Hello perl monks.

I had written a script to show this

my $Hash = { "A" => ["HYU"], "B" => ["TU6"], "C" => [ "11", "09", "88", "2" ], "D" => [ "01", "11" ] };
display as thus:
A, B, C, D HYU TU6 11 01 09 11 88 2

Of course, the script works, however, I 'feel' the code is not optimized enough. I had profiled the script using Devel::NYTProf to see what i could change, but yet nothing IMHO.

Please, could 'borrow' my your pair of eyes, and see if there are things that could be change.

Below is my script.
use warnings; use strict; my $Hash = { "A" => ["HYU"], "B" => ["TU6"], "C" => [ "11", "09", "88", "2" ], "D" => [ "01", "11" ] }; # get headiing print join( ",\t" => sort keys %$Hash ), $/; # get the value with the highest numbers of element my $highest_item = 0; foreach ( keys %{$Hash} ) { my $value = scalar @{ $Hash->{$_} }; $highest_item = $value if $highest_item < $value; } # re-write the data given as AoA, with data needed my @final_data; foreach my $key ( sort keys %{$Hash} ) { push @final_data => [ map { $Hash->{$key}[$_] || qq[] } 0 .. ( $highest_item - 1 ) ] +; } # print out in expected output foreach my $pos ( 0 .. $#final_data ) { foreach ( 0 .. $highest_item - 1 ) { print $final_data[$_][$pos], "\t"; } print $/; }
Thanks


In reply to Can this script be Optimized? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.