There's a number of improvements you could make. Here's a (not necessarily complete) list:

I took your original spec and produced the following script. While I kept to the spec, I made no any attempt to reproduce any parts of your script.

#!/usr/bin/env perl -l use strict; use warnings; use List::Util qw{max}; my %Hash = ( "A" => ["HYU"], "B" => ["TU6"], "C" => [ "11", "09", "88", "2" ], "D" => [ "01", "11" ] ); my @keys = sort keys %Hash; print join ",\t" => @keys; { no warnings 'uninitialized'; for my $i (0 .. max map { $#{$Hash{$_}} } @keys) { print join "\t" => map { $Hash{$_}[$i] } @keys; } }

Output:

A, B, C, D HYU TU6 11 01 09 11 88 2

Using tabs for the output worked in this instance; however, with other data, columns may be out of alignment. Also, tab widths can vary; so what looks fine here may be misaligned elsewhere. Consider using printf to format your output.

Also have a read of "Perl Performance and Optimization Techniques" for more tips you can use in your other scripts.

-- Ken


In reply to Re: Can this script be Optimized? by kcott
in thread Can this script be Optimized? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.