Thanks for pointing that out. I think I knew it was there, but was turning my head out of laziness, i replaced all of the subroutines with a single new one that seems to get the job done:

sub execute {
my $i = shift;
my $mib = "$oid{$i}$tftpserver";
  for my $host(@routers) {
    chomp $host;
    next if (($regex) and ($host !~ /$regex/));
    $filename = "$host.cfg" if ($i eq "wrnet");
    my $s = Net::SNMP->session( -hostname  => $host,
                                -community => $community );
    $s->set_request($mib, OCTET_STRING, $filename);
    my $error = $s->error;
    $s->set_request($oid{wrmem}, INTEGER, "1") if ($commit);
    $s->close;
    if ($error) {
      print "\n$error\n\n";
    } elsif ($i eq "wrnet") {
      print "\nSuccessfully wrote config to tftpserver for $host.\n\n"
+;
    } elsif ($i eq "confnet") {
      print "\nSuccessfully sent config to $host.\n\n";
    }
  }
}

[download]

humbly -c

In reply to Re: Re: Call for (gentle) critique. by c
in thread Call for (gentle) critique. by c

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.