Lvalue subroutines should have a single point of return – and not use the return keyword. So something like

my @x;
sub foo :lvalue {
    my ($cond, $i) = @_;
    if ($cond) {
        return $x[$i];
    } else {
        return $x[0];
    }
}

[download]

should instead be written as

my @x;
sub foo :lvalue {
    my ($cond, $i) = @_;
    my $lvalue;
    if ($cond) {
        $lvalue = \$x[$i];
    } else {
        $lvalue = \$x[0];
    }
    $$lvalue;
}

[download]

which is a general solution, or

my @x;
sub foo :lvalue {
    my ($cond, $i) = @_;
    my $lvalue;
    ($cond) ? $x[$i] : $x[0];
}

[download]

Edit: further notes I see you are using the mem module, which is basically useless. If you need to perform an assignment at compile time, just use a BEGIN block:

our @fields;
BEGIN { @fields=qw(one two three) }

[download]

While this is a little more verbose, you now don't need any non-standard modules. A similar rationale applies to the P package. It attempts to be very DWIM-y, but I find it's design distasteful. Here, explicitly using the builtin printf rather than the P function would have been clearer.

When posting minimal code snippets for others to reproduce a problem, then it's customary to remove such irrelevant dependencies – I don't shove my similar Util::Underscore in everyone's face.

In reply to Re: weird error message in middle-aged-perl(5.14) by amon
in thread weird error message in middle-aged-perl(5.14) by perl-diddler

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.