Without regard to the correctness or fitness of your code for your purpose, there is scope for a little tidying up. Consider:

#!/usr/bin/perl use strict; use warnings; use OSM::osm; my @fieldNames = qw(name amenity operator vending); openOsmFile($file); do { my ($id, $lon, $lat, $nodeUser, $ref1) = getNode2(); last if ! defined $id; my %fields; $fields{$_->[0]} = scalar $_->[1] for @$ref1; next if !grep {exists $fields{$_}} @fieldNames; print join ('^', $id, $lat, $lon, @fields{@fieldNames}), "\n"; } while (1); closeOsmFile();

As this is a test script the output is to the console rather than to a file. Needless to say the script is untested!

Perl is the programming world's equivalent of English

In reply to Re: from osm to mysql by GrandFather
in thread from osm to mysql by Perlbeginner1

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.