Your biggest (bug causing) problem is the use of:
length[@data_array]
instead of
length (@data_array)
There are other style-related issues, primarily dealing with localizing the scope of declared variables, and using a "c-style" "for" loop where a "perl style" would be more appropriate. Let me know if you need elaboration on either point.
UPDATE: length (@data_array) will not give you expected results either . (Thanks choroba for pointing that out) ; use
scalar(@data_array)
instead.
This is because length() takes a scalar. These statements are equivalent (return the same value):
length (@data_array) == length (scalar @data_array)
So the value returned by length is the length in bytes of the size of the array.
I.e. if there are 900 elements in the array, length() would return "3" (Whereas scalar() would return 900).
What is the sound of Perl? Is it not the sound of a wall that people have stopped banging their heads against?
-Larry Wall, 1992
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.