You are testing for the date matching on every line. This is not what you want. I think what I've put together below gets you closer.

#!/usr/local/bin/perl use warnings; use strict; use Fcntl (); my @dateParts = localtime (); my ($day, $month, $year) = @dateParts[3 .. 5]; $year += 1900; $month += 1; my $already_there = 0; open my $mon, '<', "C:\\temp\\MONTHLY.CSV" or die "Cannot read file $! +\n"; while ( defined ( my $line = <$mon> ) ) { my ( $date ) = split ',', $line; if ( $date eq "$day $month $year" ) { print "\ file has already been updated today"; $already_there++; last; } } close $mon; if ( ! $already_there ) { open my $day, "C:\\temp\\DAILY.CSV" or die "Cannot read file $!\n" +; flock $day, Fcntl::LOCK_SH; open $mon, '>>', "C:\\temp\\MONTHLY.CSV" or die "Cannot write to f +ile $!\n"; flock $mon, Fcntl::LOCK_EX; <$day>; # get past header while ( <$day> ) { print { $mon } $_; } close $day; close $mon or die "Could not complete writing to monthly file: $!\ +n"; } exit $already_there;

In reply to Re: check to see if a file has todays data in it, if it has exit if not then add data by mr_mischief
in thread check to see if a file has todays data in it, if it has exit if not then add data by john.tm

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.