You'd be wise to completely refactor the code and to separate the logic for parsing and processing.

ATM this is a maintenance nightmare (sorry)

parser

This "format" seems to have a strict grammar:

So write a _generic_ parser (and better implicitly check for correctness) by

If this parser works correctly you can start measuring the _speed_ for your huge file.

Now you are able to tell if the DB operations are the bottleneck (most likely they are)

processing

You should try to bundle many DB-operations, cause there is always a overhead.

If the complete HoH after parsing the whole file is to large, you must define "rules" which hook into the parsing.

This can be done by checking after each line for suitable callbacks to evaluate your temporary data so far.

Define a callback-hash $action{KEYWORD} holding subs to be called if a keyword is processed.

HTH! :)

Cheers Rolf

( addicted to the Perl Programming Language)


In reply to Re^3: Perl script speed by LanX
in thread Perl script speed by rr27

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.