It's not locking long enough. There's a step by step demonstration of the race condition in the linked post.

Maybe there is a chance of this occuring with sleep 0.01 but BrowserUk originally had sleeps of 1 -- I doubt this race condition could ever manifest with more than one worker .... esp when you're not using pending (like originally)... but even with the ops changed code and pending

Isn't it simpler to just

for( 1..10 ){ ## make sure we're not between DQ and $busy++ sleep 1; sleep 1 while $q->pending || $busy; }

I can't quantify the odds exactly other than to say probably never


In reply to Re^11: Proper undefine queue with multithreads by Anonymous Monk
in thread Proper undefine queue with multithreads by sanc

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.