Hello Perl Monks,

This might seem as a trivial question but I plan to read one line at a time from files I would pass as argument on the command line to my script.

The following approach works for me: 

 

#!/usr/bin/perl

use strict; 
use warnings; 

for my $file(@ARGV) {
    open my $fh, "<", "$file" or die "Cannot open file: $!";
    while (my $line = <$fh>) {
    print "$file: $line";
    }
}

[download]

I was wondering if this is the correct approach. Can you please suggest any other approaches? For some reason using a while loop inside for loop didn't seem idiomatic to me but I may be wrong as I am still learning to script with perl. For learning purposes I would appreciate if some one can suggest a more concise approach (even if it comes at the cost of readability).

Looking forward to your wisdom

Regards
Jaypal

UPDATE: Thanks everyone for all the different approaches.

In reply to Reading multiple files one line at a time from arguments by jaypal

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.