Although you have been shown various shortcuts (using especxially the while (<>) construct) applicable if you don't need to distinguish between various files, your general approach is very sound and robust. I would just slightly improve the error reporting mechanism: 
open my $fh, "<", "$file" or die "Cannot open file $file: $!";

[download]
which tells you which file you failed to open (this makes your life easier when you need to open a dozen files and one is missing, or when your program is constructing the file names by assembling various parts of such names). Aside from that, there is also the question whether you really want your program to fail if just one file is missing; this is usually what I want to do in such a situation, but there are some rare cases where I would just want a warning rather that a failure if just one file is missing from a long list of files.

In reply to Re: Reading multiple files one line at a time from arguments by Laurent_R
in thread Reading multiple files one line at a time from arguments by jaypal

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.