Hi, I'm trying to put some subroutines into a module so I can easily re-use them. But I'm not really clear on the syntax. I'm trying to access a CGI object in package main from a subroutine declared in a module. Is this sub-classing? Here's the script: 
#!/usr/bin/perl -wT

use strict;
use Shortcuts qw(debug print_at_form create_at_job);

BEGIN {&debug}

use CGI;
my $q = new CGI;
print $q->header();
print "<center>\n";
print_at_form($q);
&create_at_job("touch /home/foo/some_file\n") if $q->param('Submit');

[download]
This creates the form but when I try to submit it, I get this error: Can't call method "param" on an undefined value at /usr/lib/perl5/site_perl/5.6.0/Shortcuts.pm line 50 I think this is happening because I'm putting a COPY of the cgi object ($q) into &print_at_form so the &create_at_job doesn't know what I'm talking about. I was also wondering if I should be using this function-oriented code with an object; it doesn't seem right somehow. I tried changing $q->startform() in print_at_form to $main::q->startform() (throughout the sub) but that didn't work either. Here's the module: 
package Shortcuts;

# See the bottom of this file for the POD documentation.  Search for t
+he
# string '=head'.

use strict;
use diagnostics;
use vars qw($q @ISA @EXPORT_OK $VERSION);
use subs qw(debug);
use Exporter;
$VERSION = 1.00;
@ISA = qw(Exporter);
@EXPORT_OK = qw(debug print_at_form create_at_job);

### subroutines ###
sub debug {
        use CGI::Carp qw(carpout fatalsToBrowser);
        &carpout (\*STDOUT);
}

sub print_at_form {
    my $q = $_[0];
    print $q->startform();
    print "Hour";
    print $q->popup_menu(-name=>'hour', -values=>[1..12]);
    print "Minutes";
    print $q->popup_menu(-name=>'minute', -values=>[qw/00 05 10 15 20 
+25 30 35 40 45 50 55/]);
    print "Day";
    print $q->popup_menu(-name=>'day', -values=>[qw/Today Mon Tue Wed 
+Thu Fri Sat Sun/]);
    print $q->radio_group(-name=>'meridiem', -values=>[qw/am pm/]);
    print $q->submit(-name=>'Submit');
    print $q->endform();
    return $q;
}

sub create_at_job {
    my %time = &_untaint;
    my $string = "/usr/bin/at $time{hour}:$time{minute} $time{meridiem
+} $time{day}";
    my $pid = open(ATJOB, "| $string") or die "Couldn't fork: $!\n";
    print ATJOB $at_command;
    close(ATJOB);
    print "Your job has been scheduled for <b>$time{hour}:$time{minute
+} $time{meridiem} $time{day}</b>";
}

sub _untaint {
    my %time;
    $ENV{"PATH"} = "";
    if ($q->param('hour') =~ /^(1|2|3|4|5|6|7|8|9|10|11|12)$/) { $time
+{hour} = $1; } else { die "Can't untaint 'hour'"}
    if ($q->param('minute') =~ /^(00|05|10|15|20|25|30|35|40|45|50|55)
+$/) { $time{minute} = $1; } else { die "Can't untaint 'minute'"}
    if ($q->param('day') =~ /^(Today|Mon|Tue|Wed|Thu|Fri|Sat|Sun|)$/) 
+{ $time{day} = $1; } else { die "Can't untaint 'day'"}
    if ($q->param('meridiem') =~ /^(am|pm)$/) { $time{meridiem} = $1; 
+} else { die "Can't untaint 'meridiem'"}
    return %time;
}

1;

[download]

In reply to accessing CGI object from a subroutine in another package. by kingman

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.